44
fathersmurf
Re: Lets make XOOPS valid xhtml1.0 transitional!

its good seeing good work on source forge

43
damaster
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2007/9/9 20:20

  • damaster

  • Just can't stay away

  • Posts: 556

  • Since: 2003/5/11


Since Wanikoo contribution, dev team invite designers to work together... as you know still some style within tags and lack of unobstrusive javascript to improve accessibility on both branches. But, what a step !

Have Fun,

I like people more than machines or money. But that's me!
Lets do something good and great: Lets do open source!

42
wanikoo
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/22 17:05

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Quote:

I mentioned this before:
--------------------------------------------
& -> &
--------------------------------------------
/html/search.php
line 191
$search_url .= "&mid=$mid&action=showall&andor=$andor";
line 253
$search_url .= "&mid=$mid&action=$action&andor=$andor";
line 255
$search_url .= "&uid=$uid";
line 261
$search_url_prev = $search_url."&start=$prev";
line 269
$search_url_next = $search_url."&start=$next";

Umm...
My mistake!
(--);;
----------------
line 253
$search_url .= "&mid=$mid&action=$action&andor=$andor";
line 255
$search_url .= "&uid=$uid";
line 261
$search_url_prev = $search_url."&start=$prev";
line 269
$search_url_next = $search_url."&start=$next";
---------------
these are correct..because it has the process of htmlspecialchars() at the last stage..like this.
echo '<a href="'.htmlspecialchars($search_url_prev).'">'._SR_PREVIOUS.'</a></td>
~~~
echo '
<td align="right"><a href="'.htmlspecialchars($search_url_next).'">'._SR_NEXT.'</a></td>

My stupid mistake(--);;
Sorry!
(--)........-(_._)-.

41
Mikhail
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/19 21:49

  • Mikhail

  • Just can't stay away

  • Posts: 412

  • Since: 2003/1/19



40
chapi
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/14 14:34

  • chapi

  • Theme Designer

  • Posts: 611

  • Since: 2002/1/22


Quote:

/html/themes/x2t/style.css

/* Only IE that not affect the other Browsers */
* {scrollbar-face-color: #E9E9E9; scrollbar-highlight-color: #ffffff; scrollbar-shadow-color: #E0E0E0; scrollbar-3dlight-color: #000000; scrollbar-arrow-color: #000000; scrollbar-track-color: #ffffff; scrollbar-darkshadow-color: #000000;}
hr {height: 3px; border: 3px #D68000 solid; filter: Alpha(Opacity=100,FinishOpacity=10,Style=2); width: 95%;}

Yeah...
They are supported only in case of IE...
so...
If we want to make style.css valid, we have to remove them.
(I mean scrollbar-xxxx-xxxx and filter! )


Mozilla also supports the scrollbar styles, but they have to defined for the html tag and not for the body tag in the css. So the scrollbar styles don't have to be removed completely. They just have to be inside the correct tag!

39
wanikoo
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/14 13:54

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


off the topic...
but...^^;;
Quote:

Herko Coomans wrote:
Step 1b:
CSS 2.0 compliant


Quote:

from:
http://www.w3.org/TR/CSS21

Cascading Style Sheets, level 2 revision 1 CSS 2.1 Specification

4 Syntax and basic data types
4.3 Values
4.3.2 Lengths
The format of a length value (denoted by <length> in this specification) is a <number> (with or without a decimal point) immediately followed by a unit identifier (e.g., px, em, etc.). After a zero length, the unit identifier is optional.

From:
http://www.w3.org/TR/CSS21/fonts.html
15.3 Font family: the 'font-family' property
Style sheet designers are encouraged to offer a generic font family as a last alternative. Generic font family names are keywords and must NOT be quoted.
<generic-family>
In the example above, the last value is a generic family name. The following generic families are defined:
'serif' (e.g. Times)
'sans-serif' (e.g. Helvetica)
'cursive' (e.g. Zapf-Chancery)
'fantasy' (e.g. Western)
'monospace' (e.g. Courier)

-------------------------------------------------------
/html/themes/default/style.css
line3
table {width: 100%; margin: 5; padding: 5; font-size: small}
To:
table {width: 100%; margin: 5px; padding: 5px; font-size: small}

After this fix, it will be valid.
------------------------------------------------------------
/html/themes/phpkaox/style.css, styleMAC.css, styleNN.css
line1
table { width: 100%; margin: 5; padding: 5; font-size: small}
To:
table { width: 100%; margin: 5px; padding: 5px; font-size: small}

line6 ( I mean not ; but : )
body { font-family: Tahoma, taipei; color;#000000; font-size: 12px}
To:
body { font-family: Tahoma, taipei; color: #000000; font-size: 12px}

line6,7,8,9
body { font-family: Tahoma, taipei; color: #000000; font-size: 12px}
a { font-family: Tahoma, taipei; font-size: 12px; text-decoration: none; color: #666666; font-style: normal}
a:hover { text-decoration: underline overline; font-family: Tahoma, taipei; font-size: 12px; color: #FF9966; font-style: normal}
td { font-family: Tahoma, taipei; color: #000000; font-size: 12px;border-top-width : 1px; border-right-width : 1px; border-bottom-width : 1px; border-left-width : 1px;}

To:
body { font-family: Tahoma, taipei, Verdana, Arial, Helvetica, sans-serif; color: #000000; font-size: 12px}
a { font-family: Tahoma, taipei, Verdana, Arial, Helvetica, sans-serif; font-size: 12px; text-decoration: none; color: #666666; font-style: normal}
a:hover { text-decoration: underline overline; font-family: Tahoma, taipei, Verdana, Arial, Helvetica, sans-serif; font-size: 12px; color: #FF9966; font-style: normal}
td { font-family: Tahoma, taipei, Verdana, Arial, Helvetica, sans-serif; color: #000000; font-size: 12px;border-top-width : 1px; border-right-width : 1px; border-bottom-width : 1px; border-left-width : 1px;}

After this fix, it will be valid.
--------------------------------------------------------
/html/themes/x2t/style.css

/* Only IE that not affect the other Browsers */
* {scrollbar-face-color: #E9E9E9; scrollbar-highlight-color: #ffffff; scrollbar-shadow-color: #E0E0E0; scrollbar-3dlight-color: #000000; scrollbar-arrow-color: #000000; scrollbar-track-color: #ffffff; scrollbar-darkshadow-color: #000000;}
hr {height: 3px; border: 3px #D68000 solid; filter: Alpha(Opacity=100,FinishOpacity=10,Style=2); width: 95%;}

Yeah...
They are supported only in case of IE...
so...
If we want to make style.css valid, we have to remove them.
(I mean scrollbar-xxxx-xxxx and filter! )

/html/themes/x2t/styleNN.css
line 17
hr {height: 1px; #D68000 solid; width: 95%;}
To:
hr {height: 1px; border: 3px #D68000 solid; width: 95%;}

After this fix, it will be valid.
-------------------------------------------------------

38
wanikoo
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/13 15:38

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Quote:

An XML declaration is not required in all XML documents; however XHTML document authors are strongly encouraged to use XML declarations in all their documents. Such a declaration is required when the character encoding of the document is other than the default UTF-8 or UTF-16 and no encoding was determined by a higher-level protocol. Here is an example of an XHTML document. In this example, the XML declaration is included.
Quote:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE html
PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<title>Virtual Library</title>
</head>
<body>
<p>Moved to <a href="http://example.org/">example.org</a>.</p>
</body>
</html>


Umm...
How about adding the XML declaration ??
(I mean:<?xml version="1.0" encoding="UTF-8"?>)
Is there any reason that XOOPS omit this line ??

Umm..
as for mambo
echo '<?xml version="1.0" encoding="'$iso[1] .'"?' .'>';
    
?>
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    <html xmlns="http://www.w3.org/1999/xhtml">


as for xaraya
echo "<?xml version="1.0"?>n<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">n<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">n<head><title>Error</title><body>$msg</body></html>";


As for mambo,xaraya, all pages(maybe--;;) are strictly conforming documents..although they're pages for error message.

but... as for xoops, I think it still lacks consistency.
Quote:

A Strictly Conforming XHTML Document is an XML document that requires only the facilities described as mandatory in this specification. Such a document must meet all of the following criteria:
1,It must conform to the constraints expressed in one of the three DTDs found in DTDs and in Appendix B.

2,The root element of the document must be html.

3,The root element of the document must contain an xmlns declaration for the XHTML namespace [XMLNS]. The namespace for XHTML is defined to behttp://www.w3.org/1999/xhtml.

4,There must be a DOCTYPE declaration in the document prior to the root element. The public identifier included in the DOCTYPE declaration must reference one of the three DTDs found in DTDs using the respective Formal Public Identifier. The system identifier may be changed to reflect local system conventions.

5, The DTD subset must not be used to override any parameter entities in the DTD.


ex)
-----------------------
#debug popup window

in case of XOOPS 2.0.10
/html/footer.php
$content '<html><head><meta http-equiv="content-type" content="text/html; charset='._CHARSET.'" /><meta http-equiv="content-language" content="'._LANGCODE.'" /><title>'.$xoopsConfig['sitename'].'</title><link rel="stylesheet" type="text/css" media="all" href="'.getcss($xoopsConfig['theme_set']).'" /></head><body>'.$xoopsLogger->dumpAll().'<div style="text-align:center;"><input class="formButton" value="'._CLOSE.'" type="button" onclick="javascript:window.close();" /></div></body></html>';


/html/header.php
$content '<html><head><meta http-equiv="content-type" content="text/html; charset='._CHARSET.'" /><meta http-equiv="content-language" content="'._LANGCODE.'" /><title>'.$xoopsConfig['sitename'].'</title><link rel="stylesheet" type="text/css" media="all" href="'.getcss($xoopsConfig['theme_set']).'" /></head><body>'.$xoopsLogger->dumpAll().'<div style="text-align:center;"><input class="formButton" value="'._CLOSE.'" type="button" onclick="javascript:window.close();" /></div></body></html>';


/html/include/cp_functions.php
$content '<html><head><meta http-equiv="content-type" content="text/html; charset='._CHARSET.'" /><meta http-equiv="content-language" content="'._LANGCODE.'" /><title>'.$xoopsConfig['sitename'].'</title><link rel="stylesheet" type="text/css" media="all" href="'.getcss($xoopsConfig['theme_set']).'" /></head><body>'.$xoopsLogger->dumpAll().'<div style="text-align:center;"><input class="formButton" value="'._CLOSE.'" type="button" onclick="javascript:window.close();" /></div></body></html>';


in case of XOOPS 2.1.0 dev
/html/class/logger.php
$content '<html><head>
                    <meta http-equiv="content-type" content="text/html; charset='
._CHARSET.'" />
                    <meta http-equiv="content-language" content="'
._LANGCODE.'" />
                    <title>'
.$xoopsConfig['sitename'].'</title>
                    <link rel="stylesheet" type="text/css" media="all" href="'
.xoops_getcss($xoopsConfig['theme_set']).'" />
                    </head>
                    <body>'
.$this->dumpAll().'
                    <div style="text-align:center;">
                    <input class="formButton" value="'
._CLOSE.'" type="button" onclick="javascript:window.close();" />
                    </div>
                    </body>
                    </html>'
;


------------------------
/html/pmlite.php
echo "<html><head><meta http-equiv='Refresh' content='0; url=".$jump."' /></head><body></body></html>";


-------------------
/html/extras/login.php
<html>
  <
head>
    <
meta http-equiv="content-type" content="text/html; charset='._CHARSET.'" />
    <
meta http-equiv="content-language" content="'._LANGCODE.'" />
    <
title>'.$xoopsConfig['sitename'].'</title>
    <
link rel="stylesheet" type="text/css" media="all" href="'.XOOPS_URL.'/xoops.css" />


---------------
/html/install/index.php
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<
html>


--------------------
/html/install/install_tpl.php
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<
html>


-------------------
/html/modules/system/admin/blocksadmin/main.php
$dummyhtml '<html><head><meta http-equiv="content-type" content="text/html; charset='._CHARSET.'" /><meta http-equiv="content-language" content="'._LANGCODE.'" /><title>'.$xoopsConfig['sitename'].'</title><link rel="stylesheet" type="text/css" media="all" href="'.getcss($xoopsConfig['theme_set']).'" /></head><body><table><tr><th>'.$myblock->getVar('title').'</th></tr><tr><td>'.$myblock->getContent('S'$bctype).'</td></tr></table></body></html>';


--------------
/html/modules/system/admin/tplsets/main.php
$dummylayout '<html><head><meta http-equiv="content-type" content="text/html; charset='._CHARSET.'" /><meta http-equiv="content-language" content="'._LANGCODE.'" /><title>'.$xoopsConfig['sitename'].'</title><style type="text/css" media="all">';


-------------------
/html/modules/system/admin/version/main.php
echo "<html>n<head>n";
echo 
"<meta http-equiv="Content-Type" content="text/htmlcharset="._CHARSET.""></meta>n";
echo 
"<title>".htmlspecialchars($xoopsConfig['sitename'])."</title>n";


-----------------
/html/modules/system/templates/system_redirect.html
<html>
<
head>
<
meta http-equiv="Content-Type" content="text/html; charset=<{$xoops_charset}>" />
<
meta http-equiv="Refresh" content="<{$time}>; url=<{$url}>" />
<
title><{$xoops_sitename}></title>

37
damaster
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/12 14:52

  • damaster

  • Just can't stay away

  • Posts: 556

  • Since: 2003/5/11


That's right, Herko!
I think we agree on this, we both want to give Wanikoo or any other user a chance to improve XOOPS - powered by all !
And thanks for the words Herko, you know that's not the only reason i like you, we both like XOOPS and the people who made it.

Be fair, be honest, be a wise headleader, that's all i wish you and all XOOPS users!



As Wanikoo still pointing out,
let's do something good and great!

- Xoops.

I like people more than machines or money. But that's me!
Lets do something good and great: Lets do open source!

36
wanikoo
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/12 14:45

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Quote:

I mentioned like this:
-----------------------------------
pages with form class (ex: edituser.php)
--------------------------------

</td></tr><input type='hidden' name='uid' id='uid' value='1' /><tr><td>
or
</td></tr><tr><input type='hidden' name='uid' id='uid' value='1' /><td>
or
<table><input type='hidden' name='uid' id='uid' value='1' /><tr><td>
or
</td></tr><input type='hidden' name='uid' id='uid' value='1' /></table>

This kind of coding above always give us some error message like this....

document type does not allow element "input" here

Refer to this page
http://www.w3.org/TR/2002/REC-xhtml1-20020801/DTD/xhtml1-transitional.dtd

So..
If we use form classes such as XoopsTableForm(tableform.php), XoopsThemeForm(themeform.php) with XoopsFormHidden(formhidden.php),
we can never get the message," "This Page Is Valid XHTML 1.0 Transitional!" from W3 validator.

Umm...
I think there are some solutions for this problem..


fixed in XOOPS 2.1.0 dev like this.

tableform.php
$hidden "";
        
$ret $this->getTitle()."n<form name='".$this->getName()."' id='".$this->getName()."' action='".$this->getAction()."' method='".$this->getMethod()."'".$this->getExtra().">n<table border='0' width='100%'>n";
        foreach ( 
$this->getElements() as $ele ) {
            if ( !
$ele->isHidden() ) {
                
$ret .= "<tr valign='top' align='left'><td>".$ele->getCaption();
                if (
$ele->getDescription() != '') {
                    
$ret .= '<br /><br /><span style="font-weight: normal;">'.$ele->getDescription().'</span>';
                }
                
$ret .= "</td><td>".$ele->render()."</td></tr>";
            } else {
                
$hidden .= $ele->render()."n";
            }
        }
        
$ret .= "</table>".$hidden."n</form>n";

themeform.php
$hidden "";
        
$required =& $this->getRequired();
        
$ret "<form name='".$this->getName()."' id='".$this->getName()."' action='".$this->getAction()."' method='".$this->getMethod()."' onsubmit='return xoopsFormValidate_".$this->getName()."();'".$this->getExtra().">n<table width='100%' class='outer' cellspacing='1'><tr><th colspan='2'>".$this->getTitle()."</th></tr>";
        
//$count = 0;
        
foreach ( $this->getElements() as $ele ) {
            if (!
is_object($ele)) {
                
$ret .= $ele;
            } elseif (!
$ele->isHidden()) {
                
//if ($count % 2 == 0) {
                    
$class 'even';
                
//} else {
                //    $class = 'odd';
                //}
                
$ret .= "<tr valign='top' align='left'><td class='head'>".$ele->getCaption();
                if (
$ele->getDescription() != '') {
                    
$ret .= '<br /><br /><span style="font-weight: normal;">'.$ele->getDescription().'</span>';
                }
                
$ret .= "</td><td class='$class'>".$ele->render()."</td></tr>";
                
//$count++;
            
} else {
                
$hidden .= $ele->render()."n";
            }
        }
        
$ret .= "</table>".$hidden."n</form>n";
        
$ret .= $this->renderValidationJStrue );

Yeah...
fixed^^...cool~~~
but not complete...

/class/xoopsform/grouppermform.php
this file also needs the same fix.

foreach (array_keys($elements) as $i) {
            if (!
is_object($elements[$i])) {
                
$ret .= $elements[$i];
            } elseif (!
$elements[$i]->isHidden()) {
                
$ret .= "<tr valign='top' align='left'><td class='head'>" $elements[$i]->getCaption();
                if (
$elements[$i]->getDescription() != '') {
                    
$ret .= '<br /><br /><span style="font-weight: normal;">' $elements[$i]->getDescription() . '</span>';
                }
                
$ret .= "</td>n<td class='even'>n" $elements[$i]->render() . "n</td></tr>n";
            } else {
                
$ret .= $elements[$i]->render();
            }
        }


and
in case that we use assign() ,I think, we also should be careful to avoid this kind of mistake.

ex) contact module
/modules/contact/index.php
~~
    
$xoopsOption['template_main'] = 'contact_contactusform.html';
~~
    
$contact_form->assign($xoopsTpl);
~~

/modules/contact/templates/contact_contactusform.html
<{$contactform.javascript}>
<
form name="<{$contactform.name}>" action="<{$contactform.action}>" method="<{$contactform.method}>" <{$contactform.extra}>>
  <
table class="outer" cellspacing="1">
    <
tr>
    <
th colspan="2"><{$contactform.title}></th>
    </
tr>
    <!-- 
start of form elements loop -->
    <{foreach 
item=element from=$contactform.elements}>
      <{if 
$element.hidden != true}>
      <
tr>
        <
td class="head"><{$element.caption}></td>
        <
td class="<{cycle values="even,odd"}>"><{$element.body}></td>
      </
tr>
      <{else}>
      <{
$element.body}>
      <{/if}>
    <{/foreach}>
    <!-- 
end of form elements loop -->
  </
table>
</
form>


PS:
from
http://www.w3.org/TR/2002/REC-xhtml1-20020801/DTD/xhtml1-transitional.dtd

<!ELEMENT table
(caption?, (col*|colgroup*), thead?, tfoot?, (tbody+|tr+))>
<!ELEMENT caption %Inline;>
<!ELEMENT thead (tr)+>
<!ELEMENT tfoot (tr)+>
<!ELEMENT tbody (tr)+>
<!ELEMENT colgroup (col)*>
<!ELEMENT col EMPTY>
<!ELEMENT tr (th|td)+>
<!ELEMENT th %Flow;>
<!ELEMENT td %Flow;>

35
Herko
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/12 14:10

  • Herko

  • XOOPS is my life!

  • Posts: 4238

  • Since: 2002/2/4 1


Quote:

Damaster wrote:
@Herko

As i mention above, Don't misunderstood me... , being fair, that's all!

I know I wanted to explain my motivations, not attack yours. If I did, I'm deeply sorry

Quote:

I'm sorry for your grand-father and sorry for you Herko.


You're young, ambitious, you don't have reasons to be jealous, you have an opportinity, since you had 'took' the XOOPS Project, to show your competences. And "keep this realist" does it means less humain ?

He died old and peacefully, surrounded by those he loved. What more could one want?

I'm not jealous. I'm not even a member of the Core Development Team. In fact, I'd love to have a larger group of core developers working on creating the next step in XOOPS evolution. And Wanikoo is a part of that already, by his contributions here. Wanikoo's skills and expertise are being monitored, and if they match the (highest) standards (for the core this is VERY important), he is more then welcome to join that team. In the meantime, his contributions are focussed on improving the core, and we take those seriously, making him a virtual member of the core devedlopment team.

Quote:

I know, you're the Head.
And it's obvious that you consider history, utopia, hope, and wise leaders to have people following "some idea" of what it should be, don't you!?

I like people more than machines or money !
But that's me, Herko.



Any way, good work All XOOPS users !

I like people more then machines too. I listen to a lot of signals from inside and outside this community. XOOPS has to set the bar high, set some provocative standards to claim it's place in the world of CMS's. That is the future I see for XOOPS. For it to grow and become an example that inspires others to grow into what they can become. To provide the tools and inspiration for that. Being realistic in this means that we need to allow people to grow to higher levels of sophistication, adding their own flavor to the project and the products. That starts, not ends with what Wanikoo is doing

So, in short, I think we agree on this, we both want to give Wanikoo a chance to add his flavor to XOOPS. Lets just give him a chance to grow

Herko

Login

Who's Online

212 user(s) are online (142 user(s) are browsing Support Forums)


Members: 0


Guests: 212


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Apr 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits