4
wanikoo
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/4 17:14

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Quote:

Herko Coomans wrote:
If you find any code or templates that need to be adjusted because of this, submit them to the trackers, so we can deal with them

Herko

Ok^^
--------------------------------
/html/viewpmsg.php

----------------------
line 68
echo "<tr align='left' class='$class'><td valign='top' width='2%' align='center'><input type='checkbox' id='msg_id[]' name='msg_id[]' value='".$pm_arr[$i]->getVar("msg_id")."' /></td>\n";

During validation check(http://validator.w3.org/ ),
the code above gives us this error message.....

Errors: character "[" is not allowed in the value of attribute "id"

so...we need to change it like this...
from
id='msg_id[]'
to
id='msg_id".$i."'

And...

<table><form> </form></table>
the structure above also gives us some error message in case of viewpmsg.php.
so we need to change it like this..
From:
<table><form> </form></table>
To:
<form><table> </table></form>

------------------------------
After this modification,
we can get this message, "This Page(viewpmsg.php) Is Valid XHTML 1.0 Transitional!" from W3 validator.

------------To be continued--------

PS:
btw,
I will make my PM-hack valid XHTML 1.0 transitional in the next version^^;;

3
Herko
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/4 14:59

  • Herko

  • XOOPS is my life!

  • Posts: 4238

  • Since: 2002/2/4 1


Submit them to the Core Trackers, so we can add these to the 2.1 code There are a number of other issues (labels, accesskeys, etc.) that an XHTML 1.0 strict valid output needs, and I think we should work towards that as well, as well as Section 508 and AAA accessibility standards. Who's up for this challenge? To test the XOOPS core (not any modules, to start with) for these standards?
- XHTML 1.0 strict
- CSS 2.0
- Section 508/AAA web accessibility

If you find any code or templates that need to be adjusted because of this, submit them to the trackers, so we can deal with them

Herko

2
risto
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/4 14:51

  • risto

  • Not too shy to talk

  • Posts: 159

  • Since: 2003/4/16


solid.

I totaly agree.

1
wanikoo
Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/4 14:47

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Let's make XOOPS valid xhtml1.0 transitional!

First,
replacing <br>,<hr> with <br />,<hr />

Empty elements must either have an end tag or the start tag must end with />
------------------------------------------
<br> -> <br />
----------------------------------------
/html/class/errorhandler.php
line 169
$output .= sprintf( "%s in file %s line %s<br>\n", $error['errstr'], $error['errfile'], $error['errline'] );

/html/modules/xoopspoll/admin/index.php
line 441
echo "<br>View Log<br> Sorry, not yet. ";

/html/modules/mydownloads/blocks/mydownloads_top.php
line 74
$form .= "&nbsp;<br>"._MB_MYDOWNLOADS_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[2]."' />&nbsp;"._MB_MYDOWNLOADS_LENGTH."";

/html/modules/mylinks/blocks/mylinks_top.php
line 71
$form .= "&nbsp;<br>"._MB_MYLINKS_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[2]."' />&nbsp;"._MB_MYLINKS_LENGTH."";

/html/modules/news/blocks/news_top.php
line68
$form .= "&nbsp;<br>"._MB_NEWS_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[2]."' />&nbsp;"._MB_NEWS_LENGTH."";


/html/modules/system/admin/banners/xoops_version.php
$modversion['author'] = "Francisco Burzi <br>(http://phpnuke.org/ )";

/html/modules/system/admin/findusers/xoops_version.php
$modversion['author'] = "Kazumi Ono<br>(http://www.myweb.ne.jp/ )";

/html/modules/system/admin/mailusers/xoops_version.php
$modversion['author'] = "Kazumi Ono<br>(http://www.myweb.ne.jp/ )";

/html/modules/system/admin/modulesadmin/xoops_version.php
$modversion['author'] = "Kazumi Ono<br>(http://www.mywebaddons.com/ )";

/html/modules/system/admin/users/xoops_version.php
$modversion['author'] = "Francisco Burzi<br>(http://phpnuke.org/ )";

/html/modules/xoopsheadline/xoops_version.php
$modversion['author'] = "Kazumi Ono<br>(https://xoops.org/http://www.xoopscube.jp/http://www.myweb.ne.jp/ )";

and in lang file
/html/modules/newbb/language/english/admin.php
define("_MD_A_YDNFOATPOTFDYAA","You did not fill out all the parts of the form.<br>Did you assign at least one moderator? Please go back and correct the form.");
/html/modules/newbb/language/english/main.php
define("_MD_ANONNOTALLOWED","Anonymous user not allowed to post.<br>Please register.");
/html/modules/sections/language/english/main.php
define("_MD_MUSTREGFIRST","You need to be a registered user or logged in to send a modify request.<br>Please register or login first!");

-------------------------------------------
<hr> -> <hr />
--------------------------------------
/html/modules/mydownloads/admin/index.php
line 335
echo "<hr>";

/html/modules/mylinks/admin/index.php
line 311
echo "<hr>";

/html/modules/sections/admin/index.php
line 49
echo "<hr>
line 61
<hr><h4><?php echo _MD_ADDARTICLE; ?></h4>
line 82
<hr><h4><?php echo _MD_LAST20ART; ?></h4>
line 103
<hr><h4><?php echo _MD_ADDNEWSEC; ?></h4>
line 146
<hr><h4><?php echo _MD_EDITARTICLE; ?></h4>

--------------------------------------------
& -> &amp;
--------------------------------------------
/html/search.php
line 191
$search_url .= "&mid=$mid&action=showall&andor=$andor";
line 253
$search_url .= "&mid=$mid&action=$action&andor=$andor";
line 255
$search_url .= "&uid=$uid";
line 261
$search_url_prev = $search_url."&start=$prev";
line 269
$search_url_next = $search_url."&start=$next";

/html/modules/system/admin/blocksadmin/blockform.php
line 61
$form->addElement(new XoopsFormLabel(_AM_CONTENT, '<a href="'.XOOPS_URL.'/modules/system/admin.php?fct=tplsets&op=edittpl&id='.$btemplate[0]->getVar('tpl_id').'">'._AM_EDITTPL.'</a>'));
line 65
$form->addElement(new XoopsFormLabel(_AM_CONTENT, '<a href="'.XOOPS_URL.'/modules/system/admin.php?fct=tplsets&op=edittpl&id='.$btemplate2[0]->getVar('tpl_id').'" target="_blank">'._AM_EDITTPL.'</a>'));

---------------------------------------------
<input ~~~~~ > -> <input ~~~~~ />
-----------------------------------------
/html/modules/system/admin/banners/banners.php
line 165
"._AM_USEHTML." <input type='checkbox' name='htmlbanner' value='1'>
line 300
echo " <input type='checkbox' name='htmlbanner' value='1' checked='checked'>";
line 302
echo " <input type='checkbox' name='htmlbanner' value='1'>";

----------------------------------------
embed -> object
-----------------------------------------
/include/functions.php

function xoops_getbanner()

From:
if (stristr($imageurl'.swf')) {
                
$bannerobject $bannerobject
                    
.'<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" width="468" height="60">'
                    
.'<param name=movie value="'.$imageurl.'">'
                    
.'<param name=quality value=high>'
                    
.'<embed src="'.$imageurl.'" quality=high pluginspage="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash"; type="application/x-shockwave-flash" width="468" height="60">'
                    
.'</embed>'
                    
.'</object>';
            } else {
                
$bannerobject $bannerobject.'<img src="'.$imageurl.'" alt="" />';
            }

( btw, in ShockwaveFlash"; Umm.. no need ; !! )

to:
if (stristr($imageurl'.swf')) {
                
$bannerobject $bannerobject
                    
.'<object type="application/x-shockwave-flash" data="'.$imageurl.'" width="468" height="60">'
                    
.'<param name="movie" value="'.$imageurl.'" />'
                    
.'<param name="quality" value="high" />'
                    
.'</object>';
            } else {
                
$bannerobject $bannerobject.'<img src="'.$imageurl.'" alt="" />';
            }

same fix needed in /html/banners.php

Read this article if you want more info.
http://www.alistapart.com/articles/flashsatay/
---------------------------------

and bug fix!

/html/modules/system/admin/smiles/smiles.php
line 70
From:
if ($smiles['display'] == 1) {
echo ' checked="checked"';
}
To:
if ($smiles['display'] == 1) {
echo ' checked="checked"';
}
echo " />";

Umm...
I think it's still not perfect.

-------To be continued---------^^;;

Login

Who's Online

150 user(s) are online (99 user(s) are browsing Support Forums)


Members: 0


Guests: 150


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: May 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits