Hi all!!

After a peacefull install the weblog module is showing on the post form duplicated "private" option check boxes.
The first one I presume must be "Disable html" and the second "Private".

I?m wondering if could be anything wrong with this piece of code on "weblog/post.php":
======================================================
// options check box
$checkbox_tray = new XoopsFormElementTray(_BL_OPTIONS ,'<br />');
$checkbox = new XoopsFormCheckBox('', 'nohtml', !$entry->doHtml());
$checkbox->addOption('nohtml', _BL_DISABLEHTML);
$checkbox_tray->addElement($checkbox);
$checkbox = new XoopsFormCheckBox('', 'private', $entry->isPrivate());
$checkbox->addOption('private', _BL_PRIVATE);
$checkbox_tray->addElement($checkbox);
$blog_form->addElement($checkbox_tray);
==========================================================
Trying to find a solution I commented out this line
====================================================
//$checkbox = new XoopsFormCheckBox('', 'private', $entry->isPrivate());
========================================================
and guess what?
now I have 4 check boxes
a pair of disable html and a pair of private!!!

Any tip???
Best regards,
Wilson
http://xoops.net.br

Well, well.......
Still wondering..............

Yes, there is a bug in the code.

The $checkbox variable must be unset() before being used a second time. To work properly the code should read:

// options check box
$checkbox_tray = new XoopsFormElementTray(_BL_OPTIONS ,'<br />');
$checkbox = new XoopsFormCheckBox('', 'nohtml', !$entry->doHtml());
$checkbox->addOption('nohtml', _BL_DISABLEHTML);
$checkbox_tray->addElement($checkbox);
unset($checkbox); //destroy first instance
$checkbox = new XoopsFormCheckBox('', 'private', $entry->isPrivate());
$checkbox->addOption('private', _BL_PRIVATE);
$checkbox_tray->addElement($checkbox);
$blog_form->addElement($checkbox_tray);

This is a good fix.

Thank you very much.

Hey thanks Venezia!

I have the same results with a maybe not so elegant solution:


// options check box
$checkbox_tray = new XoopsFormElementTray(_BL_OPTIONS ,'<br />');
$checkbox = new XoopsFormCheckBox('', 'nohtml', !$entry->doHtml());
$checkbox->addOption('nohtml', _BL_DISABLEHTML);
$checkbox_tray->addElement($checkbox);
$checkbox2 = new XoopsFormCheckBox('', 'private', $entry->isPrivate());
$checkbox2->addOption('private', _BL_PRIVATE);
$checkbox_tray->addElement($checkbox2);
$blog_form->addElement($checkbox_tray);

=======================================================

Thanks for the reply.
Regards,
Wilson

Thanks for the FIX

I hope my php skills will be up there with yours someday